Jump to content
westsdad

Warnings during compile of DSDT for Asus K53E-BBR17

Recommended Posts

There are some warnings that I'm getting while trying to compile a DSDT for an Asus K53E-BBR17 Notebook PC.


Line 7714 Warning Not all control paths return a value (_CRS)

Line 7714 Warning Reserved method must return a value (Buffer required for _CRS)

Line 12641 Warning Statement is unreachable

Line 12649 Warning Statement is unreachable


Line 7714 is as follows:

Method (_CRS, 0, NotSerialized)


Lines 12461 and 12469 are both as follows:

Return (Ones)


I'm using an extracted DSDT from my machine and the K53E.txt patch.


I'm assuming that I need a buffer created for _CRS and a "subroutine" created for Ones, but would appreciate some guidance. I'd like to do this myself if possible, but am not sure what to do.


Note that this is a new install to be able to get a DSDT created for my Asus K53E-BBR17. I have everything working on another partition except for sleep / wake, lid close / wake, and shutdown.


This fresh install only has the following kexts installed (no DSDT or Extra folder) so that I hopefully get a clean DSDT to start with:

AppleACPIPS2Nub.kext

ApplePS2Controller.kext

AppleRTC.kext (patched to prevent CMOS resets)

FakeSMC.kext

IONetworkingFamily.kext (modified for AtherosL1cEthernet)

NullCPUPowerManagement.kext (will remove when running DSDT and use patched AppleIntelCPUPowerManagement.kext for applicable OS X version)


Full up kexts will be as follows with the compiled DSDT:

AppleACPIPlatform.kext (modified for VoodooBattery)

AppleACPIPS2Nub.kext

AppleIntelCPUPowerManagement.kext (patched for applicable OS X version)

ApplePS2Controller.kext

AppleRTC.kext (patched to prevent CMOS resets)

DeviceMergeNub.kext (for Atheros AR8151)

FakeSMC.kext

IO8211Family.kext (modified for Atheros AR8151)

IOath3kfrmwr.kext (for AR3011)

IOAudioFamily.kext (modified for ALC269)

IONetworkingFamily.kext (modified for AtherosL1cEthernet)

PXHCD.kext (for USB3.0)

VoodooBattery.kext

VoodooHDA.kext (modified for HDMI)


Note that I have swapped out the OE mini-card for an Atheros AR5B195 and have 8GB of SDRAM instead of 4GB.


I've attached the untouched DSDT.dsl file as extracted.


Here's what I know about the Notebook hardware:

http://usa.asus.com/Notebooks/Versatile_Performance/K53E/#specifications


CPU: Intel® Core™ i5-2450M, 2 Cores, 2.5GHz, 3MB Cache, 25 Bus/Core Ratio

Chipset: Intel® HM65 Express Chipset

GPU: Intel® HD Graphics 3000 Mobile, 384MB VRAM

(VID: 0x8086, PID: 0x0126)

RAM: PNY 8GB, 2 x 4GB, DDR3 PC3-1333MHz Dual Channel SDRAM Memory [see Note 1]

LAN: Atheros AR8151 PCIe Gigabit Ethernet Controller

(VID: 0x1969, PID: 0x1083)

WLAN: Atheros AR9285 802.11b/g/n WiFi Adapter (part of Atheros AR5B195) [see Note 2]

(VID: 0x168C, PID: 0x002A)

Bluetooth: Atheros AR3011 Bluetooth 3.0 Adapter (part of Atheros AR5B195) [see Note 2]

(VID: 0x0CF3, PID: 0x3005 after firmware load)

Audio: Realtek ALC269 High Definition Audio

(VID: 0x, PID: 0x)

HDD: Seagate ST95005620AS Momentus XT 500GB 7200RPM Hybrid SATA

Optical: Liteon DVDRW DS-8A8SH Slim 8x SATA Super All Write

Touchpad: Elantech Touchpad

(VID: 0x, PID: 0x)

Web Cam: Alcor Micro USB2.0 0.3 Mega Pixel Fixed Web Cam

(VID: 0x058F, PID: 0xA014)

USB3.0: Asmedia USB3.0 Adapter

(VID: 0x059F, PID: 0x8007)

Card Reader: Alcor Micro USB2.0 4 -in-1 card reader (SD/ MS/ MS Pro/ MMC)

(VID: 0x058F, PID: 0x6366)

Monitor: 15.6″ LED-backlit high-definition widescreen display with 1366 x 768 screen resolution


[Note 1] Replaced OE Ramaxel Technology 4GB DDR3 PC3-1333MHz SDRAM with PNY 8GB, 2 x 4GB, DDR3 PC3-1333MHz Dual Channel Memory SDRAM.


[Note 2] Replaced OE Asureware AW-NE186H mini card with Dell DW1702 (Atheros AR5B195) mini card.


Appreciate any help / guidance.


Thanks,

Scott

DSDT.dsl.zip

Link to comment
Share on other sites

Got rid of the four warnings with the following edits and compiled the DSDT.


Still does not sleep or shutdown properly. Screen goes blank and the power on button LED is constantly on (not blinking indicating sleep mode). Have to power down in order to go any further.



Line 7714 Warning Not all control paths return a value (_CRS)

Line 7714 Warning Reserved method must return a value (Buffer required for _CRS)


Line 7714 is as follows:

Method (_CRS, 0, NotSerialized)


http://www.tonycrapx86.com/viewtopic.php?t=9229&p=255840


ORIGINAL UNMODIFIED CODE;


                Method (_CRS, 0, NotSerialized)

                {

                    If (IGDS)

                    {

                        Return (CRS)

                    }

                }

            }

        }

    }



FIXED CODE;


       Method (_CRS, 0, NotSerialized)

                {

                    If (IGDS)

                    {

                        Return (CRS)

                    }


                    Return (Buffer (One)

                    {

                        0x00

                    })

                }

            }

        }

    }



Line 12641 Warning Statement is unreachable

Line 12649 Warning Statement is unreachable


Lines 12461 and 12469 are both as follows:

Return (Ones)


http://ubuntuforums.org/archive/index.php/t-857654.html


ORIGINAL UNMODIFIED CODE;


Method (RBAT, 2, Serialized)

{

If (LNot (ECAV ()))

{

Return (Ones)

}

Acquire (MUEC, 0xFFFF)

Store (0x03, Local0)

While (Local0)

{

Store (Arg0, CDT2)

Store (Arg1, Local1)

ShiftLeft (Local1, 0x01, Local1)

Add (Local1, 0xDA, Local1)

Store (Local1, CMD1)

Store (0x7F, Local1)

While (LAnd (CMD1, Local1))

{

Decrement (Local1)

Sleep (0x01)

}

If (LEqual (CMD1, 0x00))

{

Store (CDT1, Local1)

Store (Zero, Local0)

}

Else

{

Store (Ones, Local1)

Decrement (Local0)

}

}

Release (MUEC)

Return (Local1)

Return (Ones)

}

Method (WBAT, 3, Serialized)

{

Or (Arg0, 0x80, Local3)

If (LNot (ECAV ()))

{

Return (Ones)

}

Acquire (MUEC, 0xFFFF)

Store (0x03, Local0)

While (Local0)

{

Store (Arg2, CDT1)

Store (Local3, CDT2)

Store (Arg1, Local1)

ShiftLeft (Local1, 0x01, Local1)

Add (Local1, 0xDA, Local1)

Store (Local1, CMD1)

Store (0x7F, Local1)

While (LAnd (CMD1, Local1))

{

Decrement (Local1)

Sleep (0x01)

}

}

Release (MUEC)

Return (Local1)

Return (Ones)

}


FIXED CODE;


}

Method (RBAT, 2, Serialized)

{

If (LNot (ECAV ()))

{

Return (Ones)

}

If (LEqual (Acquire (MUEC, 0xFFFF), 0x00))

{

Store (0x03, Local0)

While (Local0)

{

Store (Arg0, CDT2)

Store (Arg1, Local1)

ShiftLeft (Local1, 0x01, Local1)

Add (Local1, 0xDA, Local1)

Store (Local1, CMD1)

Store (0x7F, Local1)

While (LAnd (CMD1, Local1))

{

Decrement (Local1)

Sleep (0x01)

}

If (LEqual (CMD1, 0x00))

{

Store (CDT1, Local1)

Store (Zero, Local0)

}

Else

{

Store (Ones, Local1)

Decrement (Local0)

}

}

Release (MUEC)

Return (Local1)

}

Return (Ones)

}

Method (WBAT, 3, Serialized)

{

Or (Arg0, 0x80, Local3)

If (LNot (ECAV ()))

{

Return (Ones)

}

If (LEqual (Acquire (MUEC, 0xFFFF), 0x00))

{

Store (0x03, Local0)

While (Local0)

{

Store (Arg2, CDT1)

Store (Local3, CDT2)

Store (Arg1, Local1)

ShiftLeft (Local1, 0x01, Local1)

Add (Local1, 0xDA, Local1)

Store (Local1, CMD1)

Store (0x7F, Local1)

While (LAnd (CMD1, Local1))

{

Decrement (Local1)

Sleep (0x01)

}

}

Release (MUEC)

Return (Local1)

}

Return (Ones)

}

Link to comment
Share on other sites

I am getting the same results are you are in your first post. I am a noob, and have been having problems with SL and Lion install. I was hoping you could help me with getting as far as you have. When I try the unishit Lion install I have no USB ports working, so I went back to SL 10.6.3, I can get 10.6.6 installed but I would like Lion 10.7.3 or higher, please help.

Link to comment
Share on other sites

I was able to get all of the errors removed. I then applied basic patches to the DSDT.


Raw.aml = Your original unedited DSDT

ER.aml = Errors removed DSDT

DSDT.aml = The DSDT I applied other edits to and this is the one you should use

 

DSDT.zip

 

If you need more edits just ask and when you do post your IOreg along with it.


If you want to see a few more edits other then the ones on this page look at this blog:


http://rampagedev.wordpress.com/

Asus Rampage IV Extreme - MSI R6870 - Intel Core I7 3820 LGA 2011 - 16 GB DDR3 Corsair Dominator GT - Mountain Lion

MSI G41M-P23 - GTX 580 - Intel Core 2 Duo E6550 - 8 GB DDR3 Gskill Ripjaws - Mountain Lion

DSDT Blog: http://rampagedev.wordpress.com/

Link to comment
Share on other sites

hello


if the dsdt is already edited , what u want more ?


the warnings and remarks no problem


it can't be with errors


is not the case


save it DSDT.aml


and test it


if u tell me u gonna use a dsdt from another pc, i disaprove that , but the pc is yours.


dsdt is like underwear, u use another man underwear ?


good hack

PB Easy Note TM 86 - i5 430 M - H55M - Ram - 6 GB - Alc272 - Radeon HD 5470 512 QE/CI

Lenovo G500 - i5 3230m - HM77 - Ram - 8 GB - Conexant audio - HD 4000

My OS X Files 

Link to comment
Share on other sites

westsdad I have the exact same laptop model as you and am curious to know if you got everything working 100% ever?


I currently have used iatkos to get ml install but I am wanting an edited dsdt and most vanilla install I can get so I am currently putting togeather all the things I might need but I am unable to get all the warnings to go away when making my dsdt.


I am currently waiting for my replacement Atheros AR5B195 combo that is compatible with ML which will take a couple weeks to get here. I hope to have everything ironed out by then. Any help you can give me is very much appreciated!


I have attached my DSDT that I got clean thru windows beta dsdt editor.

I currently cannot get a clean IO Reg file as I am booting with a dsdt that was installed not for my specific system, I will get that when time permits.


my first warning are on different lines but appear to be exact same code, I changed those and compiled them away so that worked, the next part appears a bit different and I have not tried any patching there... any help would be greatly appreciated.


also I have added a samsung 830 ssd so I think I have to add something for trim support (atleast I seen an option in multishit when I had used that before)


here is before any editing just applying patch k53e and compiling.


4141 Warning _REG has no corresponding Operation Region

7769 Warning Not all control paths return a value (_CRS)

7769 Warning Reserved method must return a value (Buffer required for _CRS)

9107 Error Non-hex letters must be upper case (pnp0c14)

12727 Warning Statement is unreachable

12755 Warning Statement is unreachable

14593 Warning Reserved method should not return a value (_Q0E)

14638 Warning Reserved method should not return a value (_Q0F)


clicking fix error gets rid of the error , my 7769 line is same as your first edit and that fixes that. but the rest remain.


beta what all did you apply in your edits? do you have a new k53e.txt that works better or did you apply all the edits yourself? just looking for something easier and futureproof incase i need bios update and such.


I have included my IO Reg file now, im not sure if it works because when i try to open it i get error saying it might be corrupted but i tried saving several times to different locations and it all seems to be working.

dsdt.dsl.zip

jamesk53e.zip

Link to comment
Share on other sites

westsdad I have the exact same laptop model as you and am curious to know if you got everything working 100% ever?


I currently have used iatkos to get ml install but I am wanting an edited dsdt and most vanilla install I can get so I am currently putting togeather all the things I might need but I am unable to get all the warnings to go away when making my dsdt.


I am currently waiting for my replacement Atheros AR5B195 combo that is compatible with ML which will take a couple weeks to get here. I hope to have everything ironed out by then. Any help you can give me is very much appreciated!


I have attached my DSDT that I got clean thru windows beta dsdt editor.

I currently cannot get a clean IO Reg file as I am booting with a dsdt that was installed not for my specific system, I will get that when time permits.


my first warning are on different lines but appear to be exact same code, I changed those and compiled them away so that worked, the next part appears a bit different and I have not tried any patching there... any help would be greatly appreciated.


also I have added a samsung 830 ssd so I think I have to add something for trim support (atleast I seen an option in multishit when I had used that before)


here is before any editing just applying patch k53e and compiling.


4141 Warning _REG has no corresponding Operation Region

7769 Warning Not all control paths return a value (_CRS)

7769 Warning Reserved method must return a value (Buffer required for _CRS)

9107 Error Non-hex letters must be upper case (pnp0c14)

12727 Warning Statement is unreachable

12755 Warning Statement is unreachable

14593 Warning Reserved method should not return a value (_Q0E)

14638 Warning Reserved method should not return a value (_Q0F)


clicking fix error gets rid of the error , my 7769 line is same as your first edit and that fixes that. but the rest remain.


beta what all did you apply in your edits? do you have a new k53e.txt that works better or did you apply all the edits yourself? just looking for something easier and futureproof incase i need bios update and such.


I have included my IO Reg file now, im not sure if it works because when i try to open it i get error saying it might be corrupted but i tried saving several times to different locations and it all seems to be working.

Try This:DSDT.aml.zip

0errors. 0remarks. 0warnings.

btn_donate_SM.gif
Link to comment
Share on other sites

mirone was there a lot to change in editing those warnings away? I just got my new wifi card way earlier than expected and now have a new dsdt that includes the update. I put that up to now but for future proofing im wondering what was done so that I might be able to fix my dsdt again.

Try this:DSDT.aml.zip

btn_donate_SM.gif
Link to comment
Share on other sites

FIXED CODE;


       Method (_CRS, 0, NotSerialized)

                {

                    If (IGDS)

                    {

                        Return (CRS)

                    }


                    Return (Buffer (One)

                    {

                        0x00

                    })

                }

 

I'm sorry for bumping but it's in name of the future lol

Just wanted to say that this fix also worked for me and I've also fixed another one:

Unknown reserved name (_WDG)

Just renamed _WDG to WDG.

Source: http://forums.gentoo.org/viewtopic-t-444743-highlight-sndhdaintel.html

Mavericks 10.9.2 Retail

When you ask for support, remember to tell the bootloader you use :)

Link to comment
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now




×
  • Create New...
The popup will be closed in 15 seconds...